Adding Bytes() to get slice representation of ULID#49
Merged
peterbourgon merged 3 commits intooklog:masterfrom May 31, 2019
sabify:patch-1
Merged
Adding Bytes() to get slice representation of ULID#49peterbourgon merged 3 commits intooklog:masterfrom sabify:patch-1
peterbourgon merged 3 commits intooklog:masterfrom
sabify:patch-1
Conversation
tsenart
approved these changes
May 30, 2019
Member
|
@sabify As silly as it might sound, can you please add a test? 😇 It would be good for the test to make sure the returned slice is distinct from the original ULID array in the ways that are important. |
golangcibot
reviewed
May 31, 2019
ulid_test.go
Outdated
| id := ulid.MustNew(ulid.Timestamp(tt), entropy) | ||
| bid := id.Bytes() | ||
| bid[len(bid)-1]++ | ||
| if bytes.Compare(id.Bytes(), bid) == 0 { |
There was a problem hiding this comment.
S1004: should use bytes.Equal(id.Bytes(), bid) instead (from gosimple)
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.