Skip to content

Adding Bytes() to get slice representation of ULID #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbourgon merged 3 commits into from
May 31, 2019
+16 −0
Merged

Adding Bytes() to get slice representation of ULID #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff438f2
Adding Bytes() to get slice representation of ULID
sabify May 29, 2019
31ba2fc
Added Test For Bytes()
sabify May 31, 2019
8d45742
Added The Test For Bytes()
sabify May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ulid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,11 @@ func MustParseStrict(ulid string) ULID {
return id
}

// Bytes returns bytes slice representation of ULID.
func (u ULID) Bytes() []byte {
return u[:]
}

// String returns a lexicographically sortable string encoded ULID
// (26 characters, non-standard base 32) e.g. 01AN4Z07BY79KA1307SR9X4MV3
// Format: tttttttttteeeeeeeeeeeeeeee where t is time and e is entropy
Expand Down
11 changes: 11 additions & 0 deletions ulid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,17 @@ func TestMonotonicSafe(t *testing.T) {
}
}

func TestULID_Bytes(t *testing.T) {
tt := time.Unix(1000000, 0)
entropy := ulid.Monotonic(rand.New(rand.NewSource(tt.UnixNano())), 0)
id := ulid.MustNew(ulid.Timestamp(tt), entropy)
bid := id.Bytes()
bid[len(bid)-1]++
if bytes.Equal(id.Bytes(), bid) {
t.Error("Bytes() returned a reference to ulid underlying array!")
}
}

type safeMonotonicReader struct {
mtx sync.Mutex
ulid.MonotonicReader
Expand Down