Skip to content

Remove mathn#157

Merged
olbrich merged 5 commits intomasterfrom
no-mathn
Aug 7, 2017
Merged

Remove mathn#157
olbrich merged 5 commits intomasterfrom
no-mathn

Conversation

@olbrich
Copy link
Owner

@olbrich olbrich commented Jul 11, 2017

This experimental branch removes the requirement for mathn.

fixes #153, #139, #134, #106, #87, #73, #59, #57, #56, #17

@olbrich olbrich self-assigned this Jul 11, 2017
@olbrich olbrich merged commit 9de5951 into master Aug 7, 2017
@rposborne
Copy link
Contributor

This is fantastic work, thank you for all your hard effort on this gem.

@olbrich olbrich deleted the no-mathn branch August 31, 2017 19:41
@kreintjes
Copy link
Contributor

Also fixed #124 right?

Great work, but I think it should have been released in a Major version, since it could break all kinds of calculations. People might have gotten used to integer divisions leading to rationals (1/3 => (1/3)) instead of integers (1/3 => 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ruby-units changes behavior of Fixnum calculations

3 participants