Location NPE fix#12
Merged
sbesson merged 7 commits intoome:masterfrom Aug 10, 2017
Merged
Conversation
Member
|
Closing/reopening to include #13 in the Travis build |
Member
|
With the last fix, the tests now fail with |
Member
|
With the last commits, the tests passes and the behavior of |
Closed
This was referenced Sep 25, 2017
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue was raised on the mailing list: http://lists.openmicroscopy.org.uk/pipermail/ome-users/2017-July/006557.html
From discussions since then it was decided to adapt the same contract as used in https://docs.oracle.com/javase/8/docs/api/java/io/File.html#getParentFile-- and return null if the parent does not exist rather than throwing a
NullPointerExceptionTo test: