Location parent Javadoc#14
Closed
sbesson wants to merge 3 commits intoome:masterfrom
Closed
Conversation
Member
Author
|
Closing as per #17. This can be combined together with the Location fix when reopened. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #12, reviews the Javadoc of the modified methods to improve the link with the upstream
java.io.File.getParentandgetParentFileby copying the Javadoc ofjava.io.Fileas the description still applies generically toLocationmethodsTo test this PR, run
mvn javadoc:javadocand check the description of the two methods above are correct and the see also blocks appear and link to the correct place (can be compared with the current Javadoc at http://javadoc.io/doc/org.openmicroscopy/ome-common/5.3.2).