Skip to content

Date format search#2890

Merged
jburel merged 3 commits intoome:dev_5_0from
jburel:date-format-search
Jul 31, 2014
Merged

Date format search#2890
jburel merged 3 commits intoome:dev_5_0from
jburel:date-format-search

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Jul 30, 2014

Fix the formatting of the date in the central panel. The date was off by 12 hours due to the fact that am or pm was not indicated.
Also handled the fact that the acquisition could be null. This is mainly relevant for develop. see gh-1240

To test:

  • Log in as user dv password ome
  • search for images e.g. IAGFP in insight, and perform the same search in web
  • Check that the time in the central panel is the same.

This PR does not address the general date formatting issue reported on the trello card https://trello.com/c/2vdtlj9e/267-date-format-and-display

I have attached screenshot of the date formatting before and after the change.
cc @mtbc @dominikl

Before:

datebeforechange

After

dateafterchange

@jburel jburel added the dev_5_0 label Jul 30, 2014
@atarkowska
Copy link
Copy Markdown
Member

all looks good, tested with P/D/I/S/P. good to go

@atarkowska
Copy link
Copy Markdown
Member

As a part of ongoing client unification work I was wondering why there is no creation date in Insight for all type of containers in metadata panel?

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Jul 31, 2014

@aleksandra-tarkowska: I have added your comment to the trello card.
I also noticed an issue (not related to this PR). insight does not show the imported date when data imported using "in-place" import

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Jul 31, 2014

@aleksandra-tarkowska Thanks, merging

jburel added a commit that referenced this pull request Jul 31, 2014
@jburel jburel merged commit 55fedf4 into ome:dev_5_0 Jul 31, 2014
@jburel jburel deleted the date-format-search branch July 31, 2014 09:17
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Aug 6, 2014

--rebased-to #2913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants