Skip to content

Date format search develop#2913

Merged
joshmoore merged 3 commits intoome:developfrom
jburel:date-format-search-develop
Aug 7, 2014
Merged

Date format search develop#2913
joshmoore merged 3 commits intoome:developfrom
jburel:date-format-search-develop

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Aug 6, 2014

Fix the formatting of the date in the central panel. The date was off by 12 hours due to the fact that am or pm was not indicated.
Also handled the fact that the acquisition could be null. This is mainly relevant for develop. see gh-1240

To test:

  • Log in as user dv password ome
  • search for images e.g. IAGFP in insight, and perform the same search in web
  • Check that the time in the central panel is the same.

This PR does not address the general date formatting issue reported on the trello card https://trello.com/c/2vdtlj9e/267-date-format-and-display

I have attached screenshot of the date formatting before and after the change.
cc @mtbc @dominikl

Before:

datebeforechange

After

dateafterchange

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Aug 6, 2014

--rebased-from #2890

@jburel jburel mentioned this pull request Aug 6, 2014
@jburel jburel added the develop label Aug 6, 2014
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Aug 6, 2014

restarted travis

@mtbc
Copy link
Copy Markdown
Member

mtbc commented Aug 7, 2014

Good to merge.

joshmoore added a commit that referenced this pull request Aug 7, 2014
@joshmoore joshmoore merged commit a8c1d53 into ome:develop Aug 7, 2014
@sbesson sbesson added this to the 5.1.0-m1 milestone Oct 14, 2014
@jburel jburel deleted the date-format-search-develop branch October 29, 2014 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants