Skip to content

Fix weblient crash and handle broken image links in public shares correctly#3153

Merged
joshmoore merged 3 commits intoome:developfrom
dpwrussell:public_broken_links
Nov 5, 2014
Merged

Fix weblient crash and handle broken image links in public shares correctly#3153
joshmoore merged 3 commits intoome:developfrom
dpwrussell:public_broken_links

Conversation

@dpwrussell
Copy link
Copy Markdown
Member

This fixes the webclient crash introduced in #3124 when viewing shares with broken image links. Previously to this they were rendered as a special broken link, now it doesn't get to that point because of a webclient crash.

Testing Instructions

  • Create a share with some images
  • Delete one of those images
  • Try and load the share, a broken link icon should be displayed instead of a webclient crash.

@atarkowska
Copy link
Copy Markdown
Member

@atarkowska
Copy link
Copy Markdown
Member

Thanks for finding bugs, next time please report it straight to the PR when was still open ;-)

Instead of default 'Image' indicate that images are deleted in the tree
@dpwrussell
Copy link
Copy Markdown
Member Author

@aleksandra-tarkowska Thanks, forgot about that.

Edited description:

It also now fixes how the broken links display in the tree and removes the old template code from the tree which was not used any more.

@pwalczysko
Copy link
Copy Markdown
Member

The workflow as described in the header of this PR is fine.

I have 2 issues (for another PR ?):

  • when the broken link image thumbnail is double clicked, an 404 page comes up (see screenshot)
  • when an image is removed from the share using selection in the tree and then Hitting the Delete Key on keyboard, the image vanishes from the tree but not from the central pane, this stays so even after reload

screen shot 2014-10-31 at 10 02 57

@dpwrussell
Copy link
Copy Markdown
Member Author

@pwalczysko Thanks. Yes, those are both issues with the current implementation as well so another PR would be best. The latter is fixed #3141 already.

@sbesson sbesson added the develop label Nov 3, 2014
joshmoore added a commit that referenced this pull request Nov 5, 2014
Fix weblient crash and handle broken image links in public shares correctly
@joshmoore joshmoore merged commit 7602d2d into ome:develop Nov 5, 2014
@atarkowska
Copy link
Copy Markdown
Member

--rebased-to #3172

@sbesson sbesson added this to the 5.1.0-m2 milestone Nov 26, 2014
@dpwrussell dpwrussell deleted the public_broken_links branch September 17, 2015 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants