Fix weblient crash and handle broken image links in public shares correctly#3153
Merged
joshmoore merged 3 commits intoome:developfrom Nov 5, 2014
dpwrussell:public_broken_links
Merged
Fix weblient crash and handle broken image links in public shares correctly#3153joshmoore merged 3 commits intoome:developfrom dpwrussell:public_broken_links
joshmoore merged 3 commits intoome:developfrom
dpwrussell:public_broken_links
Conversation
Member
Member
|
Thanks for finding bugs, next time please report it straight to the PR when was still open ;-) |
Instead of default 'Image' indicate that images are deleted in the tree
Member
Author
|
@aleksandra-tarkowska Thanks, forgot about that. Edited description: It also now fixes how the broken links display in the tree and removes the old template code from the tree which was not used any more. |
Member
|
The workflow as described in the header of this PR is fine. I have 2 issues (for another PR ?):
|
Member
Author
|
@pwalczysko Thanks. Yes, those are both issues with the current implementation as well so another PR would be best. The latter is fixed #3141 already. |
joshmoore
added a commit
that referenced
this pull request
Nov 5, 2014
Fix weblient crash and handle broken image links in public shares correctly
Member
|
--rebased-to #3172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes the webclient crash introduced in #3124 when viewing shares with broken image links. Previously to this they were rendered as a special broken link, now it doesn't get to that point because of a webclient crash.
Testing Instructions