refactoring share templates to remove duplicates

[atarkowska]

This PR remove all data manager templates used in Public tab.

To test use users: share1 and share2 (make sure they do not belong to the same group):

---

• Log in as share1
• Select images add to basket
• Create a share with at least one user (user MUST NOT belong to the group where that image was imported): In the central window, click on the basket icon, choose Manage basket, choose images to share and use the Globe icon to create a share.
• Go to Public tab (left-hand Panel). Select the share. Check that the number of images in the share is correct i.e. Share Count
• Check than images in the share can be viewed using the Preview. Double click on the image and open the Full viewer
• Check also if you can browse through the data in Data tab (if you don't see anything different or any shares in the tree and if center panel works ok, including double clicking on thumbnails)
• Check if you can comment on share

---

• Log in as share2
• Go to Public tab (left-hand Panel). Select the share. Check that the number of images in the share is correct i.e. Share Count
• Check than images in the share can be viewed using the Preview. Double click on the image and open the Full viewer
• Check also if you can browse through the data in Data tab (if you don't see anything different or any shares in the tree and if center panel works ok, including double clicking on thumbnails)
• Check if you can comment on share

---

cc: @will-moore @pwalczysko

[bpindelski]

This works as described. The only thing I found confusing was the icon above the share, next to All members:

[atarkowska]

These should address icon issue and few more

[bpindelski]

The icon issue is solved, but now the share seems to be broken for user share2 on trout. I can see the thumbnails, but clicking on any of the images to bring up the full viewer ends with an error.

Probably related error message

2014-10-23 11:11:02,227 ERROR [                     omeroweb.decorators] (proc.24015) prepare_share_connection:144 Error retrieving share connection.
Traceback (most recent call last):
  File "/opt/hudson/workspace/OMERO-5.1-merge-deploy/src/dist/lib/python/omeroweb/decorators.py", line 141, in prepare_share_connection
    if share.getOwner().id != conn.getUserId():
AttributeError: 'NoneType' object has no attribute 'getOwner'

[atarkowska]

404 link was fixed, @bpindelski let me know if you still get this error message, I need to know exactly what action throws that exception. Couldn't reproduce it locally

[bpindelski]

Thanks, @aleksandra-tarkowska. Today, when I got the error, I was following this PR's description. So I created users share1 and share2, gave user share1 some images and created a share. Then logged in as share2 and tried to view the images from the share in the full viewer. That's when I got the 404. I'll re-test tomorrow.

[bpindelski]

This looks better now. There were no 404s. Also, the error message didn't appear in the log files. Looks good to merge.

[joshmoore]

@pwalczysko : don't know if this needs to be taken into account re: scenarios for release of 5.1, though perhaps we're doing all of them regardless. 😄. And thanks, @aleksandra-tarkowska, merging.

[atarkowska]

--rebased-to #3154

[pwalczysko]

@aleksandra-tarkowska @joshmoore : The changes mentioned here have been incorporated into the Share scenario in https://github.com/openmicroscopy/ome-internal/pull/191