Skip to content

refactoring share templates to remove duplicates (rebased onto dev_5_0)#3154

Merged
joshmoore merged 5 commits intoome:dev_5_0from
atarkowska:rebased/dev_5_0/share_fixes
Nov 3, 2014
Merged

refactoring share templates to remove duplicates (rebased onto dev_5_0)#3154
joshmoore merged 5 commits intoome:dev_5_0from
atarkowska:rebased/dev_5_0/share_fixes

Conversation

@atarkowska
Copy link
Copy Markdown
Member

This is the same as gh-3124 but rebased onto dev_5_0.


This PR remove all data manager templates used in Public tab.

To test use users: share1 and share2 (make sure they do not belong to the same group):


  • Log in as share1
  • Select images add to basket
  • Create a share with at least one user (user MUST NOT belong to the group where that image was imported): In the central window, click on the basket icon, choose Manage basket, choose images to share and use the Globe icon to create a share.
  • Go to Public tab (left-hand Panel). Select the share. Check that the number of images in the share is correct i.e. Share Count
  • Check than images in the share can be viewed using the Preview. Double click on the image and open the Full viewer
  • Check also if you can browse through the data in Data tab (if you don't see anything different or any shares in the tree and if center panel works ok, including double clicking on thumbnails)
  • Check if you can comment on share

  • Log in as share2
  • Go to Public tab (left-hand Panel). Select the share. Check that the number of images in the share is correct i.e. Share Count
  • Check than images in the share can be viewed using the Preview. Double click on the image and open the Full viewer
  • Check also if you can browse through the data in Data tab (if you don't see anything different or any shares in the tree and if center panel works ok, including double clicking on thumbnails)
  • Check if you can comment on share

cc: @will-moore @pwalczysko

@atarkowska
Copy link
Copy Markdown
Member Author

--rebased-from #3124

@jburel jburel added the dev_5_0 label Oct 30, 2014
@jburel
Copy link
Copy Markdown
Member

jburel commented Oct 31, 2014

  • Select an image in the share
  • Go to preview tab
  • Click Copy (rendering settings)
  • Go to another image in the share
  • Click Paste (rendering settings)
    Error below
("error in call","Traceback (most recent call last):
  File "/opt/hudson/workspace/OMERO-5.0-merge-deploy/src/dist/lib/python/omeroweb/webgateway/views.py", line 1045, in wrap
    rv = f(request, *args, **kwargs)
  File "/opt/hudson/workspace/OMERO-5.0-merge-deploy/src/dist/lib/python/omeroweb/webgateway/views.py", line 1636, in copy_image_rdef_json
    userid = fromimg.getOwner().getId()
AttributeError: 'NoneType' object has no attribute 'getOwner'

@jburel
Copy link
Copy Markdown
Member

jburel commented Oct 31, 2014

Double-click on the image does not work, only Launch full viewer.

@jburel
Copy link
Copy Markdown
Member

jburel commented Oct 31, 2014

The display of the members of the share should definitely be improved. see screenshot or log in as user-3 Share 21958 cc @gusferguson. This does not have to be done on this PR.
sharedisplay

@atarkowska
Copy link
Copy Markdown
Member Author

@jburel you cannot copy rendering settings when you are in the share. This PR is not about fixing that. Share can be definitely improved in develop this is rebase on 5.0

@jburel
Copy link
Copy Markdown
Member

jburel commented Nov 3, 2014

@aleksandra-tarkowska: as indicated previously some items can be covered in other PR since it is a rebase. The scenario also indicates "double-click". This is not working, error in scenario more that anything
Do yo have a ticket where I can add the various comments so it does not get forgotten?

@jburel
Copy link
Copy Markdown
Member

jburel commented Nov 3, 2014

clarification: I was double-clicking on preview item. Got mislead by scenario. I will add comment to the following card https://trello.com/c/9LEqQ1V3/82-share-general-comments

@jburel
Copy link
Copy Markdown
Member

jburel commented Nov 3, 2014

Merging.

joshmoore added a commit that referenced this pull request Nov 3, 2014
…are_fixes

refactoring share templates to remove duplicates (rebased onto dev_5_0)
@joshmoore joshmoore merged commit 34c655e into ome:dev_5_0 Nov 3, 2014
@joshmoore joshmoore deleted the rebased/dev_5_0/share_fixes branch November 3, 2014 13:52
@sbesson sbesson added this to the 5.0.6 milestone Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants