Skip to content

Hide empty column data#3896

Merged
joshmoore merged 9 commits intoome:metadatafrom
will-moore:hide_empty_column_data
Jul 3, 2015
Merged

Hide empty column data#3896
joshmoore merged 9 commits intoome:metadatafrom
will-moore:hide_empty_column_data

Conversation

@will-moore
Copy link
Copy Markdown
Member

This simply hides tabular data where there is no value to avoid showing empty column names in the right panel or the full viewer.

Before and after:
screen shot 2015-06-23 at 13 52 49

@joshmoore
Copy link
Copy Markdown
Member

Is there any chance this is causing https://trello.com/c/uhSaRZ7S/38-well-loading-slow-on-dogfish ? (Visually, functionality seems a-ok)

@will-moore
Copy link
Copy Markdown
Member Author

This PR is really just the last 2 commits (the rest is #3889). So the answer has to be No, I don't see how that one line of Javascript could affect loading speed.

@will-moore will-moore force-pushed the hide_empty_column_data branch from 3dc5ee7 to 552d75d Compare June 25, 2015 10:26
joshmoore added a commit that referenced this pull request Jul 3, 2015
@joshmoore joshmoore merged commit 45d3841 into ome:metadata Jul 3, 2015
@joshmoore
Copy link
Copy Markdown
Member

Merged on the basis of the sysgro review (screen=151)

@will-moore will-moore deleted the hide_empty_column_data branch February 18, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants