Hide empty column data develop#4482
Conversation
7286137 to
3ff9618
Compare
|
For the IDR I think(?) we've decided on mapping the table rows to formatted map-annotations with links, so effectively the bulk-annotation provides the data and the map-annotation will be the transformed "view". |
|
@manics But is IDR still using this code / functionality? Do we want this in the mainline? |
|
I like the idea of having json column descriptions, but I'm not sure whether to effectively make the |
This fixes 'test_get_plate_table' in test_plategrid.py
|
Works fine on cowfish. Tested both attaching the csv to a screen as well as to plate. The clickable link is created as expected. |
|
Still some points that need to be discussed, points related to "API" |
|
#4446 has now been merged. This PR will have to be reviewed post discussion. |
|
Just rebased with origin/develop so we can see that the changes in this PR are quite small. |
|
This is conflicting with #4579 - Closing to allow that to progress... |
This is #3896 from metadata, which includes #3889
See: https://trello.com/c/e4Jxa6My/11-adding-links-within-metadata
Discussion:
This PR includes several IDR customisations that allow the inclusion of links in bulk annotation tables in right panel and in viewer. These could be considered a "first draft" of this workflow and use several new techniques, such as encoding json in a table column's description. We should consider if we want to go down this route for mainline OMERO?
Testing:
This PR provides 3 steps for adding urls to Table Data.
All parts of this are speculative and up for discussion.
Gene_Symbol %% url=http://www.ensembl.org/id/%sThis will be parsed by the populate_metadata script, which will attempt to add the data as json in the Column description. E.g.
Name:
Gene_SymbolDescription:
'{"url": "http://www.ensembl.org/id/%s"}'