Skip to content

Configuration file for controlling display of bulk-annotations#4062

Closed
manics wants to merge 15 commits intoome:metadatafrom
manics:cli-metadata-yml
Closed

Configuration file for controlling display of bulk-annotations#4062
manics wants to merge 15 commits intoome:metadatafrom
manics:cli-metadata-yml

Conversation

@manics
Copy link
Copy Markdown
Member

@manics manics commented Aug 18, 2015

Not ready for review yet. This is on top of #4037
I'm opening this so it can hopefully get into the build for initial testing

This adds a new PyYAML Python requirement.

--on-hold

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(venv)[jamoore@ome-c6220-1-2 omero]$ ./OMERO-CURRENT/bin/omero metadata -h
Error loading: /opt/omero/OMERO-CURRENT/lib/python/omero/plugins/metadata.py
Traceback (most recent call last):
  File "/opt/omero/OMERO-CURRENT/lib/python/omero/cli.py", line 1367, in loadpath
    execfile(str(pathobj), loc)
  File "/opt/omero/OMERO-CURRENT/lib/python/omero/plugins/metadata.py", line 21, in <module>
    from omero.util import populate_metadata, populate_roi
  File "/opt/omero/OMERO-CURRENT/lib/python/omero/util/populate_metadata.py", line 46, in <module>
    from omero.util.metadata_utils import KeyValueListPassThrough
  File "/opt/omero/OMERO-CURRENT/lib/python/omero/util/metadata_utils.py", line 38
     REQUIRED = {"name"}
                       ^
 SyntaxError: invalid syntax

excluding

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll be python 2.6... I'll fix

@manics
Copy link
Copy Markdown
Member Author

manics commented Sep 16, 2015

Should be Python 2.6 compliant now

@manics manics mentioned this pull request Sep 16, 2015
@manics
Copy link
Copy Markdown
Member Author

manics commented Sep 16, 2015

@joshmoore should I make populate_metadata.py: import yaml optional and disable methods that require YAML? Or keep it mandatory since it's an easy dependency to install?

@joshmoore joshmoore removed the exclude label Sep 21, 2015
@joshmoore
Copy link
Copy Markdown
Member

Re-included. Considering the impact (and until we are sure we always have a virtualenv or conda env), I'd think having just the commands be disabled would be preferable.

@manics
Copy link
Copy Markdown
Member Author

manics commented Oct 2, 2015

rebased & force pushed

@manics
Copy link
Copy Markdown
Member Author

manics commented Oct 14, 2015

Closing, see #4240 instead

@manics manics closed this Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants