Skip to content

warn about Windows deprecation#4565

Closed
atarkowska wants to merge 4 commits intoome:developfrom
atarkowska:deprecate_win
Closed

warn about Windows deprecation#4565
atarkowska wants to merge 4 commits intoome:developfrom
atarkowska:deprecate_win

Conversation

@atarkowska
Copy link
Copy Markdown
Member

Following ome/omero-documentation#1437 web plugin should also warn

To test:

  • bin\omero web -h
  • bin\omero web help

try other commands from help

  • bin\omero web config ...

they should contain:

bin\omero web config nginx
WARNING: Support for Windows will be removed in OMERO 5.3, see http://blog.openmicroscopy.org/tech-issues/future-plans/deployment/2016/03/22/windows-support/

cc: @jburel

def import_django_settings(func):
def wrapper(self, *args, **kwargs):
if self._isWindows():
self.ctx.err("Windows platform will not longer be supported"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps: "Support for Windows will be removed in OMERO 5.3"? Provide http://blog.openmicroscopy.org/tech-issues/future-plans/deployment/2016/03/22/windows-support/ (or too long)?

@atarkowska
Copy link
Copy Markdown
Member Author

done

@sbesson sbesson added the develop label Apr 8, 2016
@joshmoore
Copy link
Copy Markdown
Member

Print-out for reviewers:

bin\omero web help
Support for Windows will be removed in OMERO 5.3, see http://blog.openmicroscopy.org/tech-issues/future-plans/deployment/2016/03/22/windows-support
/

@dominikl
Copy link
Copy Markdown
Member

Hm, I can't get the warning, but I used the right build and the PR seems be merged... any ideas what I'm missing?

ls29139:bin dlindner$ ./omero web --help
usage: ./omero web [-h] <subcommand> ...

OMERO.web configuration/deployment tools

Optional Arguments:
  In addition to any higher level options

  -h, --help          show this help message and exit

Subcommands:
  Use ./omero web <subcommand> -h for more information.

  <subcommand>
    help              Extended help
    start             Primary start for the OMERO.web server
    stop              Stop the OMERO.web server
    restart           Restart the OMERO.web server
    status            Status for the OMERO.web server
    iis               IIS (un-)install of OMERO.web 
    config            Output a config template for web server
    syncmedia         Advanced use: Creates needed symlinks for static media files (Performed automatically by 'start')
    clearsessions     Advanced use: Can be run as a cron job or directly to clean out expired sessions.
    call              Developer use: call appname "[executable] scriptname" args
    enableapp         Developer use: runs enable.py and then syncdb
    gateway           Developer use: Loads the blitz gateway into a Python interpreter
ls29139:bin dlindner$ ./omero version
5.2.2-238-7115acc-ice35-b281

@joshmoore
Copy link
Copy Markdown
Member

@dominikl : only works under Windows due to the call to _isWindows

@dominikl
Copy link
Copy Markdown
Member

Ah thanks! Sure, makes sense :)

@dominikl
Copy link
Copy Markdown
Member

Works fine, warning message is shown in above mentioned cases, e. g. omero web help or omero web config nginx, however not for --help on specific commands like omero web config --help, but that might be intended/not necessary.

@atarkowska
Copy link
Copy Markdown
Member Author

@dominikl thanks for testing, I had difficulty to add warning to --help as either it appears across all commands running --help or it double because the message is in decorator. At this moment I am not sure about any solution

@atarkowska atarkowska mentioned this pull request Apr 22, 2016
@atarkowska
Copy link
Copy Markdown
Member Author

as discussed cherry-picked to #4601 can be closed now

@atarkowska atarkowska closed this Apr 22, 2016
@atarkowska atarkowska deleted the deprecate_win branch November 9, 2016 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants