Skip to content

remove windows support#4782

Merged
joshmoore merged 8 commits intoome:developfrom
atarkowska:kill_win
Aug 26, 2016
Merged

remove windows support#4782
joshmoore merged 8 commits intoome:developfrom
atarkowska:kill_win

Conversation

@atarkowska
Copy link
Copy Markdown
Member

@atarkowska atarkowska commented Aug 11, 2016

test like #4565, #4589 and #4592 (see #4601 for reference)

All the appropriate plugins should fail with ERROR

That is the end of Windows

@jburel
Copy link
Copy Markdown
Member

jburel commented Aug 12, 2016

I had to update the windows laptop in order to be able to test this PR.
I will finish on Monday

@jburel
Copy link
Copy Markdown
Member

jburel commented Aug 12, 2016

You may also want to remove:
if platform.system() in ("Windows",): LOGGING_CLASS = 'logging.handlers.RotatingFileHandler' else: LOGGING_CLASS = 'omero_ext.cloghandler.ConcurrentRotatingFileHandler'
in settings.py under omeroweb

@atarkowska
Copy link
Copy Markdown
Member Author

good spot, thx

@jburel
Copy link
Copy Markdown
Member

jburel commented Aug 12, 2016

I have removed the ref to windows in the comment in the same file.
you can cherry-pick the commit if you want jburel@6f99a03
or redo the changes.

Remove windows from doc.
@jburel
Copy link
Copy Markdown
Member

jburel commented Aug 15, 2016

As expected, it dies when running the command:
bin\omero db script

windows_warning.py, line 25 in wrapper self.ctx.die.die(WINDOWS_WARNING) TypeError: die() takes at least 3 arguments (2 given)

@atarkowska
Copy link
Copy Markdown
Member Author

my apology, try now

@jburel
Copy link
Copy Markdown
Member

jburel commented Aug 16, 2016

The error message OMERO.server support was removed... is now correctly displayed when I run bin\omero db script

@jburel
Copy link
Copy Markdown
Member

jburel commented Aug 17, 2016

you can probably also delete omero_web_iis.py

@atarkowska
Copy link
Copy Markdown
Member Author

done, I hope that is all

@joshmoore
Copy link
Copy Markdown
Member

LGMT.

@joshmoore joshmoore merged commit 16ea8ac into ome:develop Aug 26, 2016
@joshmoore joshmoore deleted the kill_win branch August 26, 2016 20:09
@sbesson sbesson added this to the 5.3.0 milestone Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants