Warn of Windows deprecation in fs plugin.#4589
Warn of Windows deprecation in fs plugin.#4589ximenesuk wants to merge 2 commits intoome:developfrom
Conversation
|
This message should also being displayed for each running command. People may not run help if they already know how to use it |
|
I've added the warning to the only relevant command, the admin-only |
| template. By default the original files and import log are also | ||
| moved. | ||
| """ | ||
| if platform.system() == 'Windows': |
There was a problem hiding this comment.
you could use self._isWindows()
There was a problem hiding this comment.
I was using the same condition as on of the other examples I looked at but happy to chnage if there is a preferred style. /cc @jburel
There was a problem hiding this comment.
@ximenesuk that is true for the top level check but within a class you can access, see https://github.com/openmicroscopy/openmicroscopy/pull/4565/files#diff-ad256e5e06d156adf521e47a4cdd8c37R68.
My comment was only suggestion, no need to be changed. I am planning to make _isWindows static that we will be able to use it in init as well (next PR once all of these warnings are merged).
|
as discussed cherry-picked to #4601 can be closed now |
4 participants
As the fs plugin does deal with file level operations, particularly
fs renameit probably deserves a warning. I've added it at the top level though it may be more warranted at therenamelevel? (Though maybe the plugin is being used remotely?)The deprecation warning should appear when
omero fs --helporomero fs -his used on Windows.