populate_metadata: warn on missing image#4852
Merged
joshmoore merged 1 commit intoome:metadata52from Sep 28, 2016
Merged
Conversation
When a well is missing from a plate, a warning is printed. The same now happens when an image is missing from a dataset. Likely, a `--strict` argument should be added which will force the existence of all objects.
eleanorwilliams
approved these changes
Sep 21, 2016
eleanorwilliams
left a comment
eleanorwilliams
left a comment
There was a problem hiding this comment.
Tested on idr0023 which has missing image files using OMERO.py-5.2.3-248-c181f59-ice35-b85.
Got the 3 warnings about missing files as expected but annotation.csv file is converted to bulk table as desired.
|
Note: I don't know how to check the first point.
|
Member
Author
|
Tests tomorrow should now pass due to #4858 |
Member
|
--rebased-to #5224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When a well is missing from a plate, a warning is printed. The
same now happens when an image is missing from a dataset. Likely,
a
--strictargument should be added which will force the existenceof all objects.
Testing this PR
test/integration/metadata/test_populate.pytests continue passing.Related reading