Skip to content

populate_metadata: warn on missing image (rebased onto metadata53)#5224

Closed
atarkowska wants to merge 1 commit intoome:metadata53from
atarkowska:rebased/metadata53/populate-missing-image
Closed

populate_metadata: warn on missing image (rebased onto metadata53)#5224
atarkowska wants to merge 1 commit intoome:metadata53from
atarkowska:rebased/metadata53/populate-missing-image

Conversation

@atarkowska
Copy link
Copy Markdown
Member

This is the same as gh-4852 but rebased onto metadata53.


What this PR does

When a well is missing from a plate, a warning is printed. The
same now happens when an image is missing from a dataset. Likely,
a --strict argument should be added which will force the existence
of all objects.

Testing this PR

  1. Check all 29 test/integration/metadata/test_populate.py tests continue passing.
  2. Attempt to annotate idr0023 (cc @eleanorwilliams). All present images should be annotated.

Related reading

When a well is missing from a plate, a warning is printed. The
same now happens when an image is missing from a dataset. Likely,
a `--strict` argument should be added which will force the existence
of all objects.
@atarkowska
Copy link
Copy Markdown
Member Author

--rebased-from #4852

@atarkowska atarkowska closed this Apr 4, 2017
@atarkowska atarkowska deleted the rebased/metadata53/populate-missing-image branch April 4, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants