Skip to content

Api eventContext#5487

Closed
will-moore wants to merge 2 commits intoome:developfrom
will-moore:api_eventcontext
Closed

Api eventContext#5487
will-moore wants to merge 2 commits intoome:developfrom
will-moore:api_eventcontext

Conversation

@will-moore
Copy link
Copy Markdown
Member

@will-moore will-moore commented Sep 1, 2017

What this PR does

Adds support for /api/v0/eventcontext/ which returns the current eventContext.
Needed for clients to retrieve the current context some time after logging in.

Needs discussion:

We need to restrict public_user from accessing this since they will be able to access their sessionId and join session as a fully logged-in public user.

Testing this PR

  1. Go to /api/v0/eventcontext/ after logging in.
  2. Should see event contest JSON data.

TODO:

  • Add test

@jburel jburel added the develop label Sep 2, 2017
@will-moore will-moore changed the title Add support for eventContext Api eventContext Sep 3, 2017
@will-moore
Copy link
Copy Markdown
Member Author

Tests failing with

'url:eventcontext': build_url(request, 'api_eventcontext'. v),\nAttributeError: 'str' object has no attribute 'v'\n", "message": "'str' object has no attribute 'v'"}

e.g. https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-integration-Python27/646/testReport/OmeroWeb.test.integration.test_api_containers/TestContainers/test_container_crud_Project_/

@will-moore
Copy link
Copy Markdown
Member Author

As for #5315, this is not needed for 5.4.0 and still requires tests etc. Closing now to focus on release...

@will-moore will-moore closed this Sep 4, 2017
@will-moore will-moore deleted the api_eventcontext branch February 18, 2019 04:13
@will-moore will-moore mentioned this pull request Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants