Skip to content

Api get roi#5960

Merged
joshmoore merged 2 commits intoome:developfrom
will-moore:api_get_roi
Apr 5, 2019
Merged

Api get roi#5960
joshmoore merged 2 commits intoome:developfrom
will-moore:api_get_roi

Conversation

@will-moore
Copy link
Copy Markdown
Member

@will-moore will-moore commented Feb 27, 2019

What this PR does

This adds support for GET and DELETE of a single ROI at /api/v0/m/rois/{ID}/
I found this missing functionality to be useful in recent iviewer work on ROIs.

Testing this PR

  1. Go to /api/v0/m/rois/{ID}/ with an ROI ID and you should get ROI JSON with shapes loaded
  2. Tests should be passing

Copy link
Copy Markdown
Member

@mtbc mtbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshmoore
Copy link
Copy Markdown
Member

@will-moore : can you say anything to how you see this endpoint possibly evolving? i.e. will more be added and if so will it break the API?

@jburel
Copy link
Copy Markdown
Member

jburel commented Apr 4, 2019

@will-moore ping in case you missed the question?

@will-moore
Copy link
Copy Markdown
Member Author

Sorry - This was just a small missing feature I wanted to add. It doesn't break any of the existing API. I'm not planning to add anything more just now. Of course, there's a lot of places where we could expand on the JSON api, e.g. #5315, #5487, annotations, shapes, search, rendering settings, updates & deletes etc

@joshmoore
Copy link
Copy Markdown
Member

Assuming all the simple get/delete endpoints match, then 👍 merging.

@joshmoore joshmoore merged commit 4ace554 into ome:develop Apr 5, 2019
@joshmoore joshmoore deleted the api_get_roi branch April 5, 2019 11:04
@jburel jburel added this to the 5.5.0 milestone Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants