Parallel fixes#6156
Merged
sbesson merged 4 commits intoome:developfrom Nov 21, 2019
Merged
Conversation
Member
Author
|
Note: this PR is ready to go as is, but one shouldn't assume that parallel integration tests are currently safe. |
sbesson
approved these changes
Nov 21, 2019
Member
sbesson
left a comment
sbesson
left a comment
There was a problem hiding this comment.
This PR has been included for many days and tests have been reliably green with it included - see https://py3-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/61/testReport/ and https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/242/testReport/ as examples.
Reviewed changes inline and most of them still maintain preserve the coverage of the tests while reducing assumptions on single-threaded test running against the server.
As this starts to conflict with other PRs, merging immediately as a first step towards Python integration test parallelization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are intended to reduce the number of spurious errors and warnings that occur when running the python tests with
pytest-xdist(e.g.-n16). The most common issue seen so far is that a test assumes the state in the database is not changed by any other thread.