Deprecated plugins test#6183
Merged
joshmoore merged 1 commit intoome:developfrom Nov 27, 2019
Merged
Conversation
Member
|
Conflicting PR. Removed from build OMERO-push#277. See the console output for more details.
|
sbesson
force-pushed
the
deprecated_plugins_test
branch
2 times, most recently
from
907dd68 to
0f910e8
Compare
Member
|
This looks good to be in terms of 124. I very much assume things aren't being fully tested, so things may go red tomorrow. If so, we can review removing these files completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to ome/omero-py#124
The renaming of the
metadataandimportplugins in theomero-pyrepository prevents the import and the execution of all OMERO.py tests - see https://py3-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/64/testReport/(root)/(empty)/OmeroPy_test_integration_clitest_test_metadata/This should fix the import to match the renaming done in #124. As the decoupled plugins have now been upgraded to be Python 3 and are tested via omero-test-infra, an alternative would be to remove these tests.