[ENGA3-297]: Fixed the issue of logging secret key in clear text.#55
Closed
aashishgurung wants to merge 1 commit intomasterfrom
Closed
[ENGA3-297]: Fixed the issue of logging secret key in clear text.#55aashishgurung wants to merge 1 commit intomasterfrom
aashishgurung wants to merge 1 commit intomasterfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
ajzkk
approved these changes
Sep 6, 2022
davidhanh
requested changes
Oct 21, 2022
Comment on lines
+88
to
+92
|
|
||
| # Replacing characters with * other than the first 4 characters | ||
| display_key = self.api_key[:4] + (len(self.api_key) - 4)*'*' | ||
|
|
||
| logger.debug('Authorization: %s', display_key) |
There was a problem hiding this comment.
I think we can just remove logger.debug('Authorization: %s', self.api_key) on L88 and L111
Author
|
Fixed the issue from another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixed the issue of logging secret key in clear text.
Jira Ticket: #297
Description
The key to be displayed is stored in a new variable
display_key. It will store the first 4 character in plain text and remaining characters are replaced by*.Environments