Skip to content

[ENGA3-297]: Fixed the issue of logging secret key in clear text. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aashishgurung wants to merge 1 commit into from
Closed

[ENGA3-297]: Fixed the issue of logging secret key in clear text. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.

# Order is important. The last matching pattern has the most precedence.
# So if a pull request only touches javascript files, only these owners
# will be requested to review.
# example: *.js @octocat @github/js

# These owners will be the default owners for everything in the repo.
* @aashishgurung @ajzkk
6 changes: 5 additions & 1 deletion omise/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ def send(self, method, path, payload=None, headers=None):
request_headers = self._build_headers(headers)

logger.info('Sending HTTP request: %s %s', method.upper(), request_path)
logger.debug('Authorization: %s', self.api_key)

# Replacing characters with * other than the first 4 characters
display_key = self.api_key[:4] + (len(self.api_key) - 4)*'*'

logger.debug('Authorization: %s', display_key)
Comment on lines +88 to +92
Copy link
Copy Markdown

@davidhanh davidhanh Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove logger.debug('Authorization: %s', self.api_key) on L88 and L111

logger.debug('Payload: %s', request_payload)
logger.debug('Headers: %s', request_headers)

Expand Down