Skip to content

Update to Cadence v1.3.0#6779

Merged
turbolent merged 7 commits into
masterfrom
auto-update-onflow-cadence-v1.3.0
Jan 21, 2025
Merged

Update to Cadence v1.3.0#6779
turbolent merged 7 commits into
masterfrom
auto-update-onflow-cadence-v1.3.0

Conversation

@turbolent
Copy link
Copy Markdown
Member

@turbolent turbolent commented Dec 3, 2024

Description

Automatically update to:

Required for #6761

@turbolent turbolent requested a review from Kay-Zee as a code owner December 3, 2024 23:17
@turbolent
Copy link
Copy Markdown
Member Author

turbolent commented Dec 4, 2024

NotSame checks pointer inequality; the input was not a pointer. This
caused a failure once testify was updated to explicitly catch and throw
an error in this case.
@jordanschalm
Copy link
Copy Markdown
Member

@turbolent Pushed 662fc0d to address (1). Thanks for linking the testify changes 🙇.

Copy link
Copy Markdown
Contributor

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @turbolent for updating to Cadence v1.3.0! 🎉

@turbolent turbolent enabled auto-merge December 18, 2024 22:26
@turbolent
Copy link
Copy Markdown
Member Author

@onflow/flow-access Could you please take another look at the failing AN test?

@turbolent turbolent requested a review from a team as a code owner January 17, 2025 20:56
@turbolent
Copy link
Copy Markdown
Member Author

turbolent commented Jan 17, 2025

@onflow/flow-cadence-execution

I just merged flow-go master into #6779 and am seeing a couple new unit test failures for engine/execution, see https://github.com/onflow/flow-go/actions/runs/12836724195/job/35799063596?pr=6779:

  • TestFailedTxWillNotChangeStateCommitment: Condition never satisfied
  • TestTransactionFeeDeduction: implementation error in derived data cache: expected program missing in cache for location: f8d6e0586b0a20c7.FlowStorageFees

Can someone familiar with these please take a look?

@janezpodhostnik
Copy link
Copy Markdown
Contributor

janezpodhostnik commented Jan 21, 2025

I have noticed TestFailedTxWillNotChangeStateCommitment being flaky. I will look into that.

I cannot reproduce the failure with TestTransactionFeeDeduction. Did you see that locally? It could be that the test was cancelled due to the other test failing.

@turbolent turbolent added this pull request to the merge queue Jan 21, 2025
Merged via the queue into master with commit fedc48a Jan 21, 2025
@turbolent turbolent deleted the auto-update-onflow-cadence-v1.3.0 branch January 21, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants