[v0.37] Port internal fixes#6937
Merged
Merged
Conversation
* adding backward compatibility for v0.37.25 * Update engine/common/version/version_control.go Co-authored-by: Jan Bernatik <jan.bernatik@flowfoundation.org> --------- Co-authored-by: Jan Bernatik <jan.bernatik@flowfoundation.org>
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
fxamacker
approved these changes
Jan 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
peterargue
approved these changes
Jan 27, 2025
SupunS
approved these changes
Jan 27, 2025
Member
Author
|
One unrelated unit test, |
NotSame checks pointer inequality; the input was not a pointer. This caused a failure once testify was updated to explicitly catch and throw an error in this case.
Member
Author
|
Cherry-picked @jordanschalm's fix: #6779 (comment) |
j1010001
approved these changes
Jan 27, 2025
zhangchiqing
approved these changes
Jan 27, 2025
AlexHentschel
approved these changes
Jan 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port https://github.com/onflow/flow-go-internal/compare/v0.37-public...v0.37
Effectively updates to Cadence v1.0.4 and atree v0.9.0