-
Notifications
You must be signed in to change notification settings - Fork 60
Fix dashboard report image download #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@omarkhan Test failing here, but it may just need to be rerun. |
|
@Kelketek the tests are passing now, yay |
|
👍 |
|
@bradenmacdonald do you want to review this one as well? |
|
@omarkhan Not necessary, thanks. I will review the edx-release hash update PR though. |
|
@omarkhan Actually never mind I'm not going to review any of these PRs. I was only going to review this master PR if it was a merge from |
|
@bradenmacdonald do I need to get thumbs up from @tobz on this PR as well? |
|
@omarkhan No, the |
|
@bradenmacdonald thanks that's what I figured, just wanted to make sure before merging |
6118a36 to
0ef0a74
Compare
Fix dashboard report image download
Associated PRs: - open-craft/problem-builder#107 (Fix dashboard report image download) - open-craft/problem-builder#108 (Add instructions for enabling dashboard in studio) - open-craft/problem-builder#109 (Use dashboard image from master branch in tests) - open-craft/problem-builder#111 (StepBuilder: Fix inconsistent feedback for MCQs)
The dashboard report image download can currently fail in 2 different ways:
SecurityErroris thrown, and nothing happens.//(no explicit protocol) or the url is relative (e.g./static/...), and it hasn't yet been cached by the browser, it will fail to show up in the downloaded report.This pull request fixes both issues, by:
This pull request also extends the integration tests to test report downloads.