Skip to content

StepBuilder: Fix inconsistent feedback for MCQs #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsjeyd merged 1 commit into from
Mar 24, 2016
Merged

StepBuilder: Fix inconsistent feedback for MCQs #111

itsjeyd merged 1 commit into from
Mar 24, 2016

Conversation

@itsjeyd
Copy link
Member

@itsjeyd itsjeyd commented Mar 23, 2016

cf. MCKIN-3907

Test instructions

  1. Create new unit and add StepBuilder block to it.
  2. Set "Max. attempts allowed" to 1 and "Extended feedback" to True for StepBuilder block.
  3. Add MentoringStep block to StepBuilder.
  4. Add MCQ block to MentoringStep.
  5. Add two Choice blocks to MCQ.
  6. Add two Tip blocks to MCQ, one for each Choice (with custom "Content").
  7. Add ReviewStep block to StepBuilder.
  8. Add ScoreSummary block to ReviewStep.
  9. Publish.
  10. Complete StepBuilder block in LMS/Apros and "Review grade".
  11. Jump back to MCQ by clicking corresponding link. Observe that feedback and result (checkmark) for choice you selected is shown right away.
  12. Reload page.
  13. Repeat step 10. Observe that feedback and result (checkmark) for choice you selected is shown right away.
  14. Click "Review final grade" button to go back to review step, without reloading page.
  15. Repeat step 10. Observe that feedback and result (checkmark) for choice you selected is shown right away.

@jbzdak
Copy link
Contributor

jbzdak commented Mar 24, 2016

+1 All good and tested.

jbzdak
jbzdak reviewed Mar 24, 2016
View reviewed changes
problem_builder/public/js/step.js
// handleReview is responsible for setting the "checked" property to true
// for each choice that the student selected as part of their most recent submission.
// If it is called after handleSubmit, the check mentioned above will fail,
// and no feedback will be displayed.
Copy link
Contributor

@jbzdak jbzdak Mar 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! Documenting non-obvious behavior of code is something we should do more oftent.

@itsjeyd itsjeyd merged commit 8b4fd30 into master Mar 24, 2016
itsjeyd added a commit to open-craft/openedx-platform that referenced this pull request Mar 24, 2016
@itsjeyd
Hash update: Problem Builder
0751884 
Associated PRs:

- open-craft/problem-builder#107 (Fix dashboard report image download)
- open-craft/problem-builder#108 (Add instructions for enabling dashboard in studio)
- open-craft/problem-builder#109 (Use dashboard image from master branch in tests)
- open-craft/problem-builder#111 (StepBuilder: Fix inconsistent feedback for MCQs)
@itsjeyd itsjeyd mentioned this pull request Mar 24, 2016
Merged
@itsjeyd itsjeyd mentioned this pull request Aug 9, 2016
Merged
3 tasks
@xitij2000 xitij2000 deleted the fix-inconsistent-feedback branch December 13, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itsjeyd @jbzdak