Skip to content

Conversation

@jbzdak
Copy link
Contributor

@jbzdak jbzdak commented Mar 29, 2016

This is initial implementation of OC-1441, this stops playback of videos from previous steps.

Course set up

What you need is a course where on a step you have a video, and then you can to the next step (you should still hear the video on that next step --- which is the error).

  1. Create a course with two sections, each containing a single subsection and a single unit.
  2. Each unit contains a step-builder with three steps. First step contains a video and a question, second contains a question, and the last one is the review step.
  3. In one of the subsections use a normal Video XBlock, in second use HTML with OOyala player (OOyala set-up is described in the OC-1441 issue).

Essentially you should have a course that looks like this:

* Section 1
 * Subsection 1
   * Unit 1
    * Step Builder
     * Step 1
      * Video XBlock with a video
      * Question 
    * Step 2 
     * Question
    * Step 3
     * Review
* Section 2
 * Subsection 2
   * Unit 1
    * Step Builder
     * Step 1
      * HTML Xblock with OOyala video
      * Question 
    * Step 2 
     * Question
    * Step 3
     * Review

Verification instructions

  1. Download the course attached to OC-1441 (for anyone from outside OpenCraft: this course just contains two StepBuilder units containing first step with a video, then step with a quiz and then step with a review; first block contains an Youtube video loaded using a Video XBlock, and second one contains an OOlaya video embedded using HTML Xblock).
  2. Please note that OOyala video needs to be manually started by pasting a snippet to a javascript console --- snippet is attached above the video, and looks like that: OO.ready(function() { OO.Player.create('xxx', 'yyy_zzz'); });. After you start the video it should work as it was started "normally" so tests are still valid.
  3. Go to video and block, start the video and wait until it loads, fill in the quiz and go to next step. Note that you still hear video music in the background.
  4. Check the same with the OOyala video subsection.

Testing instructions

  1. Checkout this branch.
  2. Go to video and block, start the video and wait until it loads, fill in the quiz and go to next step. Note that the video is no longer playing in the background.
  3. Fill in rest of the quiz, watch the review step, and go back to the video step. Verify that video is still working properly.
  4. Check the same with the OOyala video subsection.

@jbzdak jbzdak force-pushed the jbzdak/oc-1441/detach-step-dom-elements branch from 006e661 to 3b5a6a9 Compare March 29, 2016 21:58
@jbzdak jbzdak force-pushed the jbzdak/oc-1441/detach-step-dom-elements branch from 2272508 to b8927bb Compare March 30, 2016 13:39
@jbzdak jbzdak force-pushed the jbzdak/oc-1441/detach-step-dom-elements branch from 56ec38e to d356500 Compare March 30, 2016 14:30
}

/**
* Returns active step)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dangling ) on the end of comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbzdak Leftover ")"

@jbzdak jbzdak changed the title [WIP] OC-1441 Detach step elements from DOM or stop playback of closed steps OC-1441 Detach step elements from DOM or stop playback of closed steps Mar 30, 2016
@jbzdak
Copy link
Contributor Author

jbzdak commented Mar 30, 2016

@itsjeyd All review comments have been addressed (fixes should be visible on both PRs).

@itsjeyd
Copy link
Member

itsjeyd commented Mar 31, 2016

@jbzdak 👍 if YouTube issues can be ignored for now.

Also, we'll need to decide which approach we want to go with (this one or the one from #114) before merging.

@jbzdak
Copy link
Contributor Author

jbzdak commented Apr 4, 2016

I'm closing this one, I will post a follow up shortly.

@jbzdak jbzdak closed this Apr 4, 2016
@jbzdak jbzdak deleted the jbzdak/oc-1441/detach-step-dom-elements branch April 4, 2016 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants