-
Notifications
You must be signed in to change notification settings - Fork 60
OC-1441 Detach step elements from DOM or stop playback of closed steps #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
006e661 to
3b5a6a9
Compare
2272508 to
b8927bb
Compare
56ec38e to
d356500
Compare
| } | ||
|
|
||
| /** | ||
| * Returns active step) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a dangling ) on the end of comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbzdak Leftover ")"
|
@itsjeyd All review comments have been addressed (fixes should be visible on both PRs). |
|
I'm closing this one, I will post a follow up shortly. |
This is initial implementation of OC-1441, this stops playback of videos from previous steps.
Course set up
What you need is a course where on a step you have a video, and then you can to the next step (you should still hear the video on that next step --- which is the error).
Essentially you should have a course that looks like this:
Verification instructions
OO.ready(function() { OO.Player.create('xxx', 'yyy_zzz'); });. After you start the video it should work as it was started "normally" so tests are still valid.Testing instructions