OC-1441 PR with a proper solution #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 29, 2016 23:58
…-1441/detach-step-dom-elements-back Conflicts: problem_builder/public/js/mentoring_with_steps.js
| */ | ||
| function showStep(step_wrapper) { | ||
| step_wrapper.$element.insertAfter(step_wrapper.$anchor); | ||
| step_wrapper.$element.show(); |
Contributor
Author
There was a problem hiding this comment.
Show is still necessary as elements are hidden when initially loaded.
Contributor
Author
|
@itsjeyd This is the second solution to the issue, it's better (no hacks), but might introduce unwanted regressions. Posted as a separate PR, as I still have some doubts which solution is better overall (see the jira ticket). I will squash the commits before merge :) |
jbzdak
force-pushed
the
jbzdak/oc-1441/detach-step-dom-elements-back
branch
from
a38e9ae to
bebbe04
Compare
added 3 commits
March 31, 2016 11:11
Removed video resizing function, it's not a public JS api and the resizer object is missing as of today. It looks like video should resize itself automatically as we actually add it to the dom before each step
| self.assertEqual(len(step_builder.find_elements_by_css_selector('.sb-step')), 1) | ||
| self.rating_question(None, step_builder, controls, "5 - Extremely good", CORRECT) | ||
| self.assertEqual(len(step_builder.find_elements_by_css_selector('.sb-step')), 1) | ||
|
|
Member
There was a problem hiding this comment.
@jbzdak Two comments here:
- Could you DRY this out a little by factoring the code that checks how many steps are present into a separate method?
- I think it would be good to add one more check for the review step (at that point, no steps are present).
jbzdak
force-pushed
the
jbzdak/oc-1441/detach-step-dom-elements-back
branch
from
49d45f2 to
dece75b
Compare
jbzdak
force-pushed
the
jbzdak/oc-1441/detach-step-dom-elements-back
branch
from
dece75b to
6ac7da3
Compare
problem_builder/public/js/step.js
Outdated
| updateVideo(child); | ||
| break; | ||
| case 'sb-plot': | ||
| if (type=='sb-plot'){ |
Contributor
Author
|
Closing this one, will follow up with a proper solution shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instructions on #112.