Skip to content

Conversation

@musmanmalik
Copy link
Contributor

Missing translations added

Copy link
Contributor

@aayushagrawal9 aayushagrawal9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there merge commits for all PRs from #1 to #11? Can you please clean up the commit history

"The report is currently being generated\u2026": "Der Report wird gerade zusammengestellt\u2026",
"You have used {num_used} of 1 submission.": [
"Sie haben {num_used} von einer Einreichung verwendet.",
"Sie haben {num_used} von {max_attempts} Einreichungen verwendet. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there whitespace after the fullstop within the string?

Copy link
Contributor Author

@musmanmalik musmanmalik Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushagra Regarding white space issues that you have identified, Most of the highlighted areas belong to auto generated files. You can simply ignore this since we are not adding/deleting anything in these files manually.

"The report is currently being generated\u2026": "Generujemy raport...",
"You have used {num_used} of 1 submission.": [
"Wykorzysta\u0142e\u015b {num_used} z 1 zg\u0142oszenia.",
"Wykorzysta\u0142e\u015b {num_used} z {max_attempts} zg\u0142osze\u0144. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace again

var newcatalog = {
"All": "Tudo",
"Data export failed. Reason: <%= error %>": "Falha na exporta\u00e7\u00e3o de dados. Motivo: <%= error %>",
"All": "Tudo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the extra whitespace after the comma?


django.formats = {
"DATETIME_FORMAT": "j \\d\\e F \\d\\e Y \u00e0\\s H:i",
"DATETIME_FORMAT": "j \\d\\e F \\d\\e Y \u00e0\\s H:i",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again whitespace, why?

msgstr[0] ""
msgstr[1] ""
msgstr[0] "Sie haben {num_used} von einer Einreichung verwendet."
msgstr[1] "Sie haben {num_used} von {max_attempts} Einreichungen verwendet. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More whitespace

msgstr[2] ""
msgstr[3] ""
msgstr[0] "Wykorzystałeś {num_used} z 1 zgłoszenia."
msgstr[1] "Wykorzystałeś {num_used} z {max_attempts} zgłoszeń. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the whitespace after the full stop?

@musmanmalik
Copy link
Contributor Author

Why are there merge commits for all PRs from #1 to #11? Can you please clean up the commit history

@aayushagra This is fork updating commits, and will not effect anything since you will squash and merge which will result in one commit. If I will go for cleaning now I have to do again all which is in this PRs. I will clean this in next PRs.

@aayushagrawal9 aayushagrawal9 merged commit eb669fa into open-craft:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants