-
Notifications
You must be signed in to change notification settings - Fork 60
MCKIN-24508 Missing translations added v4 #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCKIN-24508 Missing translations added v4 #303
Conversation
New Stuff
Marge PR open-craft#271: japanese translation update
Fork Updation
[BB-2320] Added the MySQL Readme for Problem builder (open-craft#282)
fork update
Fork Update
Fork Updation
MCKIN-24633 master PR for portuguese translation isssue (open-craft#302)
aayushagrawal9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "The report is currently being generated\u2026": "Der Report wird gerade zusammengestellt\u2026", | ||
| "You have used {num_used} of 1 submission.": [ | ||
| "Sie haben {num_used} von einer Einreichung verwendet.", | ||
| "Sie haben {num_used} von {max_attempts} Einreichungen verwendet. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there whitespace after the fullstop within the string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aayushagra Regarding white space issues that you have identified, Most of the highlighted areas belong to auto generated files. You can simply ignore this since we are not adding/deleting anything in these files manually.
| "The report is currently being generated\u2026": "Generujemy raport...", | ||
| "You have used {num_used} of 1 submission.": [ | ||
| "Wykorzysta\u0142e\u015b {num_used} z 1 zg\u0142oszenia.", | ||
| "Wykorzysta\u0142e\u015b {num_used} z {max_attempts} zg\u0142osze\u0144. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace again
| var newcatalog = { | ||
| "All": "Tudo", | ||
| "Data export failed. Reason: <%= error %>": "Falha na exporta\u00e7\u00e3o de dados. Motivo: <%= error %>", | ||
| "All": "Tudo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the extra whitespace after the comma?
|
|
||
| django.formats = { | ||
| "DATETIME_FORMAT": "j \\d\\e F \\d\\e Y \u00e0\\s H:i", | ||
| "DATETIME_FORMAT": "j \\d\\e F \\d\\e Y \u00e0\\s H:i", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again whitespace, why?
| msgstr[0] "" | ||
| msgstr[1] "" | ||
| msgstr[0] "Sie haben {num_used} von einer Einreichung verwendet." | ||
| msgstr[1] "Sie haben {num_used} von {max_attempts} Einreichungen verwendet. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More whitespace
| msgstr[2] "" | ||
| msgstr[3] "" | ||
| msgstr[0] "Wykorzystałeś {num_used} z 1 zgłoszenia." | ||
| msgstr[1] "Wykorzystałeś {num_used} z {max_attempts} zgłoszeń. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the whitespace after the full stop?
@aayushagra This is fork updating commits, and will not effect anything since you will squash and merge which will result in one commit. If I will go for cleaning now I have to do again all which is in this PRs. I will clean this in next PRs. |
Missing translations added