Skip to content

Conversation

@Kelketek
Copy link
Member

@mtyaka

Testing instructions:

  1. Create a course, add 'step-builder' to the advanced modules.
  2. Add step builder block, add Mentoring Step to that block.
  3. You should see Video block is available for adding. Add one to see if it works.
  4. Stop CMS, install https://github.com/Stanford-Online/xblock-image-modal
  5. Go back to Mentoring Step block in the CMS
  6. See Image Modal in the available blocks list for adding. Add one to see if it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kelketek Now that this method does more than simply returns a static list, do you think it would make sense to add a unit test for it? I'm not sure how easy it is, but I'm guessing you could fake the modules that contain VideoDescriptor and ImageModal in tests.

@mtyaka
Copy link
Member

mtyaka commented Oct 16, 2015

@Kelketek I'm wondering whether we could add a test for the allowed_nested_blocks method, but otherwise the changes look good and work well both in Studio and the LMS 👍

@Kelketek
Copy link
Member Author

@mtyaka I was able to get tests in. Could you take a look at the test code?

@mtyaka
Copy link
Member

mtyaka commented Oct 16, 2015

@Kelketek Great, thanks! 👍

One of the travis checks failed, but the failure looks weird, I"m guessing it was just a temporary issue?

@Kelketek
Copy link
Member Author

@mtyaka Yeah. Most likely. I'll force a rerun and merge when it passes.

Kelketek added a commit that referenced this pull request Oct 19, 2015
Allow Videos and images to be added to Mentoring Step Block.
@Kelketek Kelketek merged commit 8d8a8f9 into master Oct 19, 2015
@Kelketek Kelketek deleted the nested-steps branch October 19, 2015 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants