Skip to content

Conversation

@itsjeyd
Copy link
Member

@itsjeyd itsjeyd commented Oct 16, 2015

This PR adds a "plot" block to Step Builder that can be used to visualize answers to pairs of rating questions.

Testing

  1. Add Step Builder to a unit.

  2. Add two Mentoring Step blocks and a Review Step block to Step Builder.

  3. Add two Rating questions to the first Mentoring Step block.

  4. Add a Plot block to the second Mentoring Step block.

  5. For each of the Rating questions, grab the corresponding "Question ID" from the EDIT dialog in Studio (last field, underneath "Label for high ratings").

  6. Bring up the EDIT dialog for the Plot block and add the following to the "Claims and associated questions" field:

    This is an important claim, 7cf9575c53d5abc43fddedc4b06ae1a835dd4bf3, 79020e44630e246077a2bce92f45562fe24769cd
    

    Make sure to replace the two hashes with the question IDs you grabbed in the previous step.

  7. Publish the unit.

  8. Complete the first step of the unit by submitting answers to the rating questions.

  9. Navigate to the second step. The plot should show the answers you gave in the form of a single point.

  10. Repeat the previous two steps as another user and make sure to choose different answers for the rating questions. When you get to the second step, the point representing the average value of all submissions for the rating questions should be located in a different place than the point representing your own answer.

@Kelketek
Copy link
Member

@itsjeyd The method of inputting the questions and labels is a bit overcomplicated. Consider making the specification a child block. Is it only allowed to have two questions, or are an arbitrary amount? You may wish to use a list field on the child block in such a case.

This PR also needs a rebase, and as you mentioned, more tests.

@Kelketek
Copy link
Member

@itsjeyd The plot points appear to be the same for me when I'm the staff or honor user even when I choose different answers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd be able to eliminate this function or significantly reduce it by using children as mentioned in the earlier comment.

@itsjeyd
Copy link
Member Author

itsjeyd commented Oct 19, 2015

@Kelketek Thanks for the feedback!

The method of inputting the questions and labels is a bit overcomplicated. Consider making the specification a child block. Is it only allowed to have two questions, or are an arbitrary amount?

I discussed the method for specifying claims to include in plots with @antoviaque in the comments of OC-1010; for the current MVP, the way it works is sufficient.

The plot points appear to be the same for me when I'm the staff or honor user even when I choose different answers.

I can't reproduce this on my end. Can you try hovering over the points to see the data? Do the numbers that you see correspond to the values that you chose for the different users?

@itsjeyd itsjeyd force-pushed the sb-plot-block branch 3 times, most recently from 5aae515 to d2b16ed Compare October 19, 2015 13:36
@Kelketek
Copy link
Member

@itsjeyd #73 contains a commit that fixes the tests. You may wish to cherry-pick the commit to run the tests, and remove it in the resulting rebase. The issue appears to stem from installing from the head of the SDK, which has some new changes that include extra logging.

I'll be looking at this shortly.

@itsjeyd
Copy link
Member Author

itsjeyd commented Oct 19, 2015

@Kelketek Thanks for the pointers, I cherry-picked b3ea5e.

@Kelketek
Copy link
Member

@itsjeyd You've got a failing test which should be easy to fix. Fix that, and it has my 👍

itsjeyd added a commit that referenced this pull request Oct 20, 2015
Step Builder: New block type: "Plot"
@itsjeyd itsjeyd merged commit 015fe14 into master Oct 20, 2015
@itsjeyd
Copy link
Member Author

itsjeyd commented Oct 20, 2015

@Kelketek Thanks for the re-review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants