-
Notifications
You must be signed in to change notification settings - Fork 60
Step Builder: New block type: "Plot" #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@itsjeyd The method of inputting the questions and labels is a bit overcomplicated. Consider making the specification a child block. Is it only allowed to have two questions, or are an arbitrary amount? You may wish to use a list field on the child block in such a case. This PR also needs a rebase, and as you mentioned, more tests. |
|
@itsjeyd The plot points appear to be the same for me when I'm the staff or honor user even when I choose different answers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd be able to eliminate this function or significantly reduce it by using children as mentioned in the earlier comment.
|
@Kelketek Thanks for the feedback!
I discussed the method for specifying claims to include in plots with @antoviaque in the comments of OC-1010; for the current MVP, the way it works is sufficient.
I can't reproduce this on my end. Can you try hovering over the points to see the data? Do the numbers that you see correspond to the values that you chose for the different users? |
5aae515 to
d2b16ed
Compare
|
@itsjeyd #73 contains a commit that fixes the tests. You may wish to cherry-pick the commit to run the tests, and remove it in the resulting rebase. The issue appears to stem from installing from the head of the SDK, which has some new changes that include extra logging. I'll be looking at this shortly. |
|
@Kelketek Thanks for the pointers, I cherry-picked b3ea5e. |
d0ac8c7 to
3296ca7
Compare
|
@itsjeyd You've got a failing test which should be easy to fix. Fix that, and it has my 👍 |
Step Builder: New block type: "Plot"
|
@Kelketek Thanks for the re-review :) |
This PR adds a "plot" block to Step Builder that can be used to visualize answers to pairs of rating questions.
Testing
Add Step Builder to a unit.
Add two Mentoring Step blocks and a Review Step block to Step Builder.
Add two Rating questions to the first Mentoring Step block.
Add a Plot block to the second Mentoring Step block.
For each of the Rating questions, grab the corresponding "Question ID" from the EDIT dialog in Studio (last field, underneath "Label for high ratings").
Bring up the EDIT dialog for the Plot block and add the following to the "Claims and associated questions" field:
Make sure to replace the two hashes with the question IDs you grabbed in the previous step.
Publish the unit.
Complete the first step of the unit by submitting answers to the rating questions.
Navigate to the second step. The plot should show the answers you gave in the form of a single point.
Repeat the previous two steps as another user and make sure to choose different answers for the rating questions. When you get to the second step, the point representing the average value of all submissions for the rating questions should be located in a different place than the point representing your own answer.