refactor: refactor sync providers#291
Merged
james-milligan merged 9 commits intoopen-feature:mainfrom Jan 23, 2023
Merged
Conversation
Contributor
|
This looks like a great improvement to the current sync / eval implementation. Ill test this properly once it is ready for review |
skyerus
reviewed
Jan 18, 2023
skyerus
reviewed
Jan 18, 2023
skyerus
reviewed
Jan 18, 2023
skyerus
reviewed
Jan 18, 2023
skyerus
reviewed
Jan 18, 2023
skyerus
reviewed
Jan 18, 2023
skyerus
reviewed
Jan 18, 2023
Kavindu-Dodan
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
Kavindu-Dodan
commented
Jan 18, 2023
This was referenced Jan 18, 2023
skyerus
reviewed
Jan 20, 2023
skyerus
approved these changes
Jan 20, 2023
toddbaert
reviewed
Jan 20, 2023
Member
|
|
toddbaert
approved these changes
Jan 20, 2023
Member
There was a problem hiding this comment.
This looks really good to me. We've added to flagd a number of times, and whenever that happens it usually creates need for a refactor to clean things up. I find the new interfaces much clearer! Thanks!
I also tested this locally a bit and found no issues.
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
refactor/refactor-sync-providers
branch
from
fb85b8d to
764255f
Compare
james-milligan
approved these changes
Jan 23, 2023
toddbaert
pushed a commit
that referenced
this pull request
Jan 30, 2023
## This PR Adds a component diagram for flag configuration providers and their interactions with the runtime and other systems. Related PR #291 --------- Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
beeme1mr
pushed a commit
that referenced
this pull request
Feb 7, 2023
@Kavindu-Dodan has contributed multiple significant changes and proposals to flagd: - multiple refactors: #291, #307 - ci/security improvements: #338, #337 - architectural proposals (some of which got some attention from outside parties!): open-feature/ofep#45, open-feature/flagd-schemas#78, #249 (comment) - load testing: #225 - documentation improvements For these reasons, I believe he should be made a CODEOWNER in this repository. NOTE: before this is merged, @Kavindu-Dodan should be added with at least `maintainer` permissions to the repo. Signed-off-by: Todd Baert <toddbaert@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Revisits sync providers and refactor them.
With this change, we get a clear isolation between runtime and sync providers (ex:- file, k8s, ....). For example, the runtime is not aware of any sync implementation details such as events. It simply coordinates sync impls, store (evaluator) and notifications. This should bring more extensibility when adding future extensions.
Below is the overview of the internals and interactions,