Skip to content

chore: add architecture overview for recent refactoring#310

Merged
toddbaert merged 7 commits intoopen-feature:mainfrom
Kavindu-Dodan:chore/add-component-diagram
Jan 30, 2023
Merged

chore: add architecture overview for recent refactoring#310
toddbaert merged 7 commits intoopen-feature:mainfrom
Kavindu-Dodan:chore/add-component-diagram

Conversation

@Kavindu-Dodan
Copy link
Copy Markdown
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Jan 23, 2023 •
edited
Loading

This PR

Adds a component diagram for flag configuration providers and their interactions with the runtime and other systems.

Related PR #291

@Kavindu-Dodan
add architecture overview for recent refactoring
f046a2e 
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
beeme1mr
beeme1mr reviewed Jan 23, 2023
View reviewed changes
Comment thread docs/other_resources/high_level_architecture.md Outdated
@Kavindu-Dodan
add description and change header
9f6e638 
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@toddbaert
Copy link
Copy Markdown
Member

toddbaert commented Jan 24, 2023

I find the label "ISync Impl Listner" (sp) a bit misleading, probable because in code/comments, we refer to it something like "DataSync channel watcher"... That is what this represents, right? I think that might be a better name. Or just "DataSync Channel"? I think we should choose a consistent name for this abstraction.

@Kavindu-Dodan
Copy link
Copy Markdown
Contributor Author

Kavindu-Dodan commented Jan 24, 2023

I find the label "ISync Impl Listner" (sp) a bit misleading, probable because in code/comments, we refer to it something like "DataSync channel watcher"... That is what this represents, right? I think that might be a better name. Or just "DataSync Channel"? I think we should choose a consistent name for this abstraction.

I agree with this. I will rephrase this to "DataSync channel listener"

@toddbaert toddbaert merged commit a114070 into open-feature:main Jan 30, 2023
@toddbaert
Copy link
Copy Markdown
Member

toddbaert commented Jan 30, 2023

@Kavindu-Dodan I meant to ask this before merge, but forgot... can you also commit the excalidraw source?

@Kavindu-Dodan Kavindu-Dodan mentioned this pull request Jan 30, 2023
Merged
toddbaert pushed a commit that referenced this pull request Jan 30, 2023
@Kavindu-Dodan
chore: Image source for image (#348)
0391848 
## This PR

Adds the image source content of the PR
#310. Source can be used with
**excalidraw**

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
raphael-wigoutschnigg-dt pushed a commit to open-feature-forking/flagd that referenced this pull request Mar 11, 2025
@github-actions
chore(main): release providers/go-feature-flag 0.1.27 (open-feature#310)
d6606c1 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert toddbaert approved these changes

@james-milligan james-milligan james-milligan approved these changes

@AlexsJones AlexsJones Awaiting requested review from AlexsJones

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kavindu-Dodan @toddbaert @beeme1mr @james-milligan