fix: make lint code name version-stable#17
Merged
tsavo-at-pieces merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
PR SummaryLow Risk Overview This removes reliance on Written by Cursor Bugbot for commit 49f4f42. Configure here. |
There was a problem hiding this comment.
Pull request overview
This PR makes the custom lint rule’s LintCode name version-stable across analyzer/custom_lint_builder API changes by using a local constant for the rule name instead of relying on LintCode name-related getters.
Changes:
- Introduce a private
_ruleNameconstant for the lint code name. - Use
_ruleNamewhen creating the static_codeand when reporting dynamicLintCodeinstances (to support per-occurrence correction messages).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tsavo-at-pieces
pushed a commit
that referenced
this pull request
Feb 24, 2026
## Changelog ## [0.1.11] - 2026-02-24 ### Added - Added runtime_ci_tooling generated files including CLAUDE.md, SETUP.md, USAGE.md, .gemini commands, and GitHub workflows ### Changed - Aligned custom_lint_builder constraints for workspace, moved it to dependencies as a git package from open-runtime fork, and added publish_to: none - Updated runtime_ci_tooling dependency to ^0.12.0 and regenerated CI workflow ### Fixed - Avoid deprecated LintCode name getters to make lint code version-stable (#17) - Fixed all analyzer lint issues by removing invalid strict-casts/inference/raw-types language options from the errors section in recommended.yaml ## Files Modified ``` .../audit/v0.1.11/explore/breaking_changes.json | 4 ++ .../audit/v0.1.11/explore/commit_analysis.json | 57 +++++++++++++++ .runtime_ci/audit/v0.1.11/explore/pr_data.json | 18 +++++ .runtime_ci/audit/v0.1.11/meta.json | 82 ++++++++++++++++++++++ .../v0.1.11/version_analysis/version_bump.json | 1 + .../version_analysis/version_bump_rationale.md | 25 +++++++ .runtime_ci/autodoc.json | 6 +- .../release_notes/v0.1.11/changelog_entry.md | 12 ++++ .../release_notes/v0.1.11/contributors.json | 5 ++ .runtime_ci/release_notes/v0.1.11/highlights.md | 4 ++ .../release_notes/v0.1.11/linked_issues.json | 12 ++++ .runtime_ci/release_notes/v0.1.11/release_notes.md | 29 ++++++++ .../release_notes/v0.1.11/release_notes_body.md | 29 ++++++++ .runtime_ci/version_bumps/v0.1.11.md | 25 +++++++ CHANGELOG.md | 19 +++++ pubspec.yaml | 2 +- 16 files changed, 326 insertions(+), 4 deletions(-) ``` ## Version Bump Rationale # Version Bump Rationale **Decision**: patch The changes introduced since the `v0.1.10` release consist entirely of bug fixes, dependency updates, CI tooling upgrades, and documentation enhancements. There are no breaking changes to the public API and no new features or lint rules were added. Therefore, a patch release is the appropriate version bump. ## Key Changes * Fixed invalid `strict-casts`, `strict-inference`, and `strict-raw-types` keys from the `errors` section in `lib/recommended.yaml` which were causing analyzer issues. * Updated deprecated `_code.name` getters in `lib/custom_lints/prefer_for_in_over_foreach_lint.dart` to fix `LintCode` instantiation and make the lint code name version-stable. * Moved `custom_lint_builder` to a proper git dependency pointing to the `open-runtime` fork (`dart_custom_lint.git`) to align leaf constraints for workspace enablement. * Bumped `runtime_ci_tooling` dependency to `^0.12.0` (fixes a pipeline failure related to rebase operations). * ... ## Contributors - @tsavo-at-pieces --- Automated release by CI/CD pipeline (Gemini CLI + GitHub Actions) Commits since v0.1.10: 11 Generated: 2026-02-24T02:26:19.388624Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LintCodename getters by using a local constant for the lint code name.Test plan
dart analyze