Skip to content

fix: make lint code name version-stable #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsavo-at-pieces merged 1 commit into from
Feb 24, 2026
Merged

fix: make lint code name version-stable #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/custom_lints/prefer_for_in_over_foreach_lint.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ import 'package:custom_lint_builder/custom_lint_builder.dart'
class PreferForInOverForEachLint extends DartLintRule {
const PreferForInOverForEachLint() : super(code: _code);

static const _ruleName = 'prefer_for_in_over_foreach';

static const _code = LintCode(
name: 'prefer_for_in_over_foreach',
name: _ruleName,
problemMessage:
'Avoid using forEach with function literals. Prefer tear-offs, for-in loops, or collection for syntax. Function literals in forEach create unnecessary closures, add runtime overhead, and limit control flow (no break/continue).',
correctionMessage:
Expand Down Expand Up @@ -48,11 +50,7 @@ class PreferForInOverForEachLint extends DartLintRule {
// Report with enhanced message
reporter.atNode(
node,
LintCode(
name: _code.lowerCaseName,
problemMessage: _code.problemMessage,
correctionMessage: refactoringSuggestion,
),
LintCode(name: _ruleName, problemMessage: _code.problemMessage, correctionMessage: refactoringSuggestion),
);
});
}
Expand Down
Loading