Add unit-test for Jaeger exporter#1151
Merged
ThomsonTan merged 10 commits intoDec 21, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1151 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 165 165
Lines 6230 6230
=======================================
Hits 5818 5818
Misses 412 412 |
ThomsonTan
reviewed
Dec 20, 2021
|
|
||
| add_executable(jaeger_exporter_test test/jaeger_exporter_test.cc) | ||
| add_definitions(-DGTEST_LINKED_AS_SHARED_LIBRARY=1) | ||
| if(GMOCK_LIB) |
Contributor
There was a problem hiding this comment.
Put this check under MSVC as well?
ThomsonTan
reviewed
Dec 20, 2021
| using namespace jaegertracing; | ||
| using namespace opentelemetry::exporter::jaeger; | ||
| using namespace opentelemetry::sdk::instrumentationlibrary; | ||
| using std::vector; |
lalitb
approved these changes
Dec 20, 2021
|
|
||
| TEST_F(JaegerExporterTestPeer, ShutdownTest) | ||
| { | ||
| auto mock_thrift_ender = new MockThriftSender; |
Member
There was a problem hiding this comment.
nit; would mock_thrift_sender be better naming?
ThomsonTan
approved these changes
Dec 21, 2021
This was referenced Jan 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1142 (issue)
Changes
Add unit-test for Jaeger exporter
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes