Add sampler header file#118
Merged
Merged
Conversation
reyang
reviewed
Jun 17, 2020
reyang
reviewed
Jun 17, 2020
reyang
reviewed
Jun 17, 2020
pyohannes
reviewed
Jun 17, 2020
reyang
reviewed
Jun 17, 2020
reyang
reviewed
Jun 17, 2020
added 2 commits
June 17, 2020 15:07
added 4 commits
June 17, 2020 17:51
reyang
reviewed
Jun 17, 2020
Contributor
Author
|
I signed it |
oulin-coder
reviewed
Jun 18, 2020
Merged
added 2 commits
June 19, 2020 19:20
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 66 66
Lines 1656 1656
=======================================
Hits 1545 1545
Misses 111 111 |
oulin-coder
reviewed
Jun 22, 2020
| * A key/value pair that can be used to set attributes. | ||
| */ | ||
| struct AttributeKeyValue { | ||
| nostd::string_view key; |
There was a problem hiding this comment.
Storing a string_view has some pitfalls - string_view is essentially a pointer to an underlying string, so it relies on the underlying string value to outlive the string_view's lifetime. If "key" isn't too large, I recommend just storing it as a string.
pyohannes
reviewed
Jun 22, 2020
added 2 commits
June 22, 2020 23:31
pyohannes
approved these changes
Jun 23, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
I have two more nits regarding the doc strings, otherwise this looks good to me. The TODOs for Links and SpanContext can remain, as this is work that still needs to be done and is not part of this PR.
Also, there is no more dependency on #117 any more, so this can be merged as soon as the doc strings are addressed.
Great job!
Merged
pyohannes
reviewed
Jun 23, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
A few more nits. Please make sure you rebase. Then I think this is ready to be merged.
pyohannes
reviewed
Jun 23, 2020
Contributor
|
Looks all good from my side and ready to merge. @reyang |
Member
|
LGTM, will merge after CI finished. |
Contributor
Author
|
Member
This seems to be a nice to have thing. On the other side, I'm guessing even with a const map, the actual value are not guaranteed to be const?
Nope. |
Merged
Closed
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
[SEMANTIC CONVENTIONS] Upgrade to weaver 0.11.0 (open-telemetry#3194)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sampler.hunder SDK.sampler.hdefines sampler and SamplingResult interface.Waiting for Support for attributes on spans #117 to merge first.