Skip to content

Always on sampler#122

Merged
reyang merged 50 commits into
open-telemetry:masterfrom
ziqizh:always-on-sampler
Jun 29, 2020
Merged

Always on sampler#122
reyang merged 50 commits into
open-telemetry:masterfrom
ziqizh:always-on-sampler

Conversation

@ziqizh
Copy link
Copy Markdown
Contributor

@ziqizh ziqizh commented Jun 19, 2020

Implements AlwayOnSampler based on the sampler interface in #118.

@ziqizh ziqizh requested a review from a team June 19, 2020 19:14
@ziqizh ziqizh force-pushed the always-on-sampler branch from 28a09a4 to 78b5be0 Compare June 19, 2020 19:23
Comment thread sdk/include/opentelemetry/sdk/trace/always_on_sampler.h Outdated
Comment thread sdk/src/trace/always_on_sampler.cc Outdated
@ziqizh ziqizh marked this pull request as ready for review June 22, 2020 22:04
Comment thread sdk/src/trace/always_on_sampler.cc Outdated
Comment thread sdk/include/opentelemetry/sdk/trace/sampler.h Outdated
Comment thread sdk/include/opentelemetry/sdk/trace/sampler.h Outdated
Comment thread sdk/include/opentelemetry/sdk/trace/sampler.h Outdated
Comment thread sdk/include/opentelemetry/sdk/trace/sampler.h Outdated
@pyohannes pyohannes mentioned this pull request Jun 26, 2020
Comment thread sdk/include/opentelemetry/sdk/trace/sampler.h
Copy link
Copy Markdown
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang merged commit 79b6141 into open-telemetry:master Jun 29, 2020
nadiaciobanu pushed a commit to nadiaciobanu/opentelemetry-cpp that referenced this pull request Jul 2, 2020
@reyang reyang mentioned this pull request Aug 25, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
[SEMANTIC CONVENTIONS] Update links to openmetrics to reference the v…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants