SamplingResult attributes fix#126
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 66 66
Lines 1656 1656
=======================================
Hits 1545 1545
Misses 111 111 |
pyohannes
approved these changes
Jun 24, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
Looks good. You can take this out of draft state.
Contributor
Author
|
Could someone with write access merge this PR please? |
Closed
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
Update dependency ubuntu to v24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two mistakes in the Sampling API
SamplingResultstruct:unique_ptr<const map>to be immutable, according to the spec