Skip to content

SamplingResult attributes fix #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reyang merged 2 commits into from
Jun 24, 2020
Merged

SamplingResult attributes fix #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d066d
minor fix
Jun 23, 2020
abba0e3
modify namespace
Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/include/opentelemetry/sdk/trace/sampler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ struct SamplingResult
{
Decision decision;
// A set of span Attributes that will also be added to the Span. Can be nullptr.
std::unique_ptr<std::map<std::string, openelemetry::common::AttributeValue>> attributes;
std::unique_ptr<const std::map<std::string, opentelemetry::common::AttributeValue>> attributes;
};

/**
Expand Down Expand Up @@ -70,7 +70,7 @@ class Sampler
trace_api::TraceId trace_id,
nostd::string_view name,
trace_api::SpanKind span_kind,
const KeyValueIterable &attributes) noexcept = 0;
const trace_api::KeyValueIterable &attributes) noexcept = 0;

/**
* Returns the sampler name or short description with the configuration.
Expand Down