Skip to content

Moving a temporary object prevents copy elision.#205

Merged
reyang merged 1 commit into
open-telemetry:masterfrom
g-easy:move
Jul 23, 2020
Merged

Moving a temporary object prevents copy elision.#205
reyang merged 1 commit into
open-telemetry:masterfrom
g-easy:move

Conversation

@g-easy
Copy link
Copy Markdown
Contributor

@g-easy g-easy commented Jul 23, 2020

Caught by: -Wpessimizing-move

@g-easy g-easy requested a review from a team July 23, 2020 08:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2020

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          96       96           
  Lines        2878     2878           
=======================================
  Hits         2754     2754           
  Misses        124      124           
Impacted Files Coverage Δ
api/include/opentelemetry/context/context.h 98.11% <100.00%> (ø)

Copy link
Copy Markdown
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This should pass tests with the fix in #207, but I think it is ready to being merged without it. @reyang

@reyang reyang merged commit e616636 into open-telemetry:master Jul 23, 2020
@g-easy g-easy deleted the move branch July 24, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants