Use gcc-4.8 for GHA legacy tests#207
Merged
Merged
Conversation
added 3 commits
July 23, 2020 08:28
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 96 96
Lines 2878 2878
=======================================
Hits 2754 2754
Misses 124 124
|
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
[SEMANTIC CONVENTIONS] Upgrade semantic conventions to 1.31.0 (open-telemetry#3297)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
CC=/usr/bin/gcc-4.8was omitted for our GHA legacy test, resulting in the use of the default Ubuntu 18.04 gcc version.This PR fixes this and makes our legacy tests actually using gcc-4.8 again (and pass). Merging this will fix other PR builder failures.