Skip to content

Use gcc-4.8 for GHA legacy tests #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reyang merged 4 commits into from
Jul 23, 2020
Merged

Use gcc-4.8 for GHA legacy tests #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c03f256
Use gcc-4.8 for legacy tests
Jul 23, 2020
9ee9acc
Fix
Jul 23, 2020
8daca18
Fx
Jul 23, 2020
38c3f79
Merge branch 'master' into use-gcc-4.8
reyang Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ jobs:
sudo ./ci/install_gcc48.sh
- name: run tests
run: ./ci/do_ci.sh bazel.legacy.test
env:
CC: /usr/bin/gcc-4.8

bazel_test:
name: Bazel
Expand Down
2 changes: 1 addition & 1 deletion exporters/ostream/src/span_exporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace exporter
namespace trace
{
OStreamSpanExporter::OStreamSpanExporter(std::ostream &sout) noexcept
: sout_{sout} {}
: sout_(sout) {}

std::unique_ptr<sdktrace::Recordable> OStreamSpanExporter::MakeRecordable() noexcept
{
Expand Down