Skip to content

Add Prometheus Exporter - Utils Implementation#250

Closed
CunjunWang wants to merge 8 commits into
open-telemetry:masterfrom
CunjunWang:prom-exporter-utils-impl
Closed

Add Prometheus Exporter - Utils Implementation#250
CunjunWang wants to merge 8 commits into
open-telemetry:masterfrom
CunjunWang:prom-exporter-utils-impl

Conversation

@CunjunWang
Copy link
Copy Markdown
Contributor

This PR implements exporter utils helper functions in the exporter/prometheus/src folder for the Prometheus Exporter project. The C++ file prometheus_exporter_utils.cc implements all the helper functions that will be called when we translate a OpenTelemetry (OTLP) metric to a Prometheus metric.

Note to reviewers:

  1. Please keep in mind that there are other PRs related to this one so codecov tests may not fully pass.
  2. There are two TODOs that will be implemented and modified later:
    1. Translating from Sketch Aggregator to Prometheus Sketch is not yet implemented.
    2. Exact Aggregator translation has some pending problems. Details are in this issue:

@CunjunWang CunjunWang requested a review from a team August 5, 2020 23:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@422b7a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #250   +/-   ##
=========================================
  Coverage          ?   92.47%           
=========================================
  Files             ?      142           
  Lines             ?     6204           
  Branches          ?        0           
=========================================
  Hits              ?     5737           
  Misses            ?      467           
  Partials          ?        0           

@CunjunWang
Copy link
Copy Markdown
Contributor Author

Refactored in #280

@CunjunWang CunjunWang closed this Aug 17, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
Bump codecov/codecov-action from 5.4.0 to 5.4.2 (open-telemetry#3362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant