Add Prometheus Collector - PrometheusCollector unit tests#262
Closed
erichsueh3 wants to merge 3 commits into
Closed
Add Prometheus Collector - PrometheusCollector unit tests#262erichsueh3 wants to merge 3 commits into
erichsueh3 wants to merge 3 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 93.29% 92.47% -0.83%
==========================================
Files 66 142 +76
Lines 1656 6204 +4548
==========================================
+ Hits 1545 5737 +4192
- Misses 111 467 +356
|
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…ld-push-action-6.x chore(deps): update docker/build-push-action action to v6.16.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the unit tests for the PrometheusCollector class. The PR for the PrometheusCollector header and source files can be found here(ADD LINK).
This PR is one in a series of PRs that aims to add a full implementation of a Prometheus Exporter within the OpenTelemetry C++ library.
Note to reviewers: Please keep in mind that this PR is dependent on the Prometheus Collector Implementation PR(#261) and the Prometheus Exporter Utils PRs (#245 and #250) so codecov tests may not fully pass.