Add json.hpp to CI and Build Tools#306
Merged
Merged
Conversation
… - ignore if either of these isn't found
Fix script bug
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 146 146
Lines 6629 6629
=======================================
Hits 6271 6271
Misses 358 358 |
maxgolov
commented
Aug 28, 2020
| sudo \ | ||
| libcurl4-openssl-dev | ||
| libcurl4-openssl-dev \ | ||
| nlohmann-json-dev \ |
Contributor
Author
There was a problem hiding this comment.
Main reason why I need to ignore the errors / skip missing, is because the package name / version is different between distros. I'm trying to keep this setup script universal to work for any recent distro (Ubuntu 16.xx, 18.xx, 20.xx).. Basically, we "install whatever available" json.hpp . Ideally we may want to reconsider, and either use PPA to install latest, OR add specific version we need as git submodule.
Member
@maxgolov would you update the description to include "why do we do this"? Thanks. |
Contributor
Author
Added description. |
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
[CMake] Add missing CMake keyword for target_link_libraries (open-telemetry#3442)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #281
Adding nlohmann/json json.hpp to CMake build.
Practical reason today:
zpagesimplementation requires nlohmann json, but it only added to Bazel build (CMake part was not done)Future considerations: