Skip to content

Add CMake Support for the JSON C++ Dependency #281

@jajanet

Description

@jajanet

Is your feature request related to a problem?
At the time of writing, there's a JSON dependency with only a Bazel build created. Since we're committed to both CMake and Bazel, there also needs to be CMake support.

Describe the solution you'd like
CMake can be added using vcpkg install nlohmann-json as long as Bazel build is added.

Describe alternatives you've considered
After a CMake build is created for a quick fix to have full support for the JSON dependency, any current and future issues with building for Github dependencies in both CMake and Bazel can ideally be amended using Github submodules. This would mean nlohmann-json would be added under a submodules folder along with other repositories (Google Test, Google Benchmark, Protobuf). OTel Java currently does this as seen here. This will be reasoned with in a future Github issue.

Additional context
#190 (review)

@maxgolov

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions