Add JSON C++ support - Bazel#190
Conversation
maxgolov
left a comment
There was a problem hiding this comment.
I assume this is for Bazel only right now. There are two approaches for CMake:
vcpkg install nlohmann-json- safe; OR- add it as submodule to
third_party- I don't think we agreed yet we can use submodules.
I think this would be necessary to make it work cross-platform. There were some discussions about vendoring strategies with CMake/Bazel, but no final conclusions were made. There's also the option to just vendor the single include version. It almost feels like a bit of an overkill to add a submodule if all we need is just a single header. |
|
This is still marked as a draft. Is it intended to solve all the TODOs mentioned in this PR? |
|
I think we could leave it as is, and merge. @maxgolov said he can handle adding CMake support. Alternatively, different features could also add JSON C++ via CMake by adding it manually to their CMake file: |
Ok. Can you please write issues for TODOs that remain open after merging this PR? |
|
Will do, thank you! |
Adding typecast without whom c++26 build fails (open-telemetry#3281)
PR to import JSON in C++ as an external dependency. Would be useful for zPages/TraceZ and other SDK features for OpenTelemetry. @maxgolov
Reference: nlohmann/json#1606